feat: safe ecc_sum and tests #244
Merged
+117
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint test is not passing (fix clippy) |
jonathanpwang
requested changes
Jan 6, 2024
jonathanpwang
requested changes
Apr 5, 2024
jonathanpwang
approved these changes
Apr 9, 2024
jonathanpwang
added a commit
to axiom-crypto/snark-verifier
that referenced
this pull request
Apr 26, 2024
After axiom-crypto/halo2-lib#244 the `EccChip::sum` was renamed `EccChip::sum_unsafe`. We update the naming to still use the `sum_unsafe` function so that snark verifier circuits do not change.
jonathanpwang
added a commit
to axiom-crypto/snark-verifier
that referenced
this pull request
Apr 27, 2024
* chore: keep old behavior of `EccInstructions::sum_with_const` After axiom-crypto/halo2-lib#244 the `EccChip::sum` was renamed `EccChip::sum_unsafe`. We update the naming to still use the `sum_unsafe` function so that snark verifier circuits do not change. * chore: fix clap version to prevent rust version issues * ci: install `svm-rs` with its `Cargo.lock` (#48) * chore: use solc-select instead of svm to avoid rust version issues --------- Co-authored-by: Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a safe version of sum that allows summands to be points at infinity and allows output to be point at infinity